From 8ef4e231ec2cec3df928b5e34e14fa524cd266d5 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 27 Mar 2019 17:14:33 -0400 Subject: [PATCH] gdk: Stop implementing set_role All but the X implementation of these were empty anyway. And the X one is just setting a property. --- gdk/broadway/gdksurface-broadway.c | 7 ------- gdk/quartz/gdksurface-quartz.c | 12 ------------ gdk/wayland/gdksurface-wayland.c | 7 ------- gdk/x11/gdksurface-x11.c | 22 ---------------------- 4 files changed, 48 deletions(-) diff --git a/gdk/broadway/gdksurface-broadway.c b/gdk/broadway/gdksurface-broadway.c index 4a3b02d8b1..bc2ca62eed 100644 --- a/gdk/broadway/gdksurface-broadway.c +++ b/gdk/broadway/gdksurface-broadway.c @@ -501,12 +501,6 @@ gdk_broadway_surface_set_title (GdkSurface *surface, { } -static void -gdk_broadway_surface_set_role (GdkSurface *surface, - const gchar *role) -{ -} - static void gdk_broadway_surface_set_startup_id (GdkSurface *surface, const gchar *startup_id) @@ -1358,7 +1352,6 @@ gdk_surface_impl_broadway_class_init (GdkSurfaceImplBroadwayClass *klass) impl_class->set_urgency_hint = gdk_broadway_surface_set_urgency_hint; impl_class->set_geometry_hints = gdk_broadway_surface_set_geometry_hints; impl_class->set_title = gdk_broadway_surface_set_title; - impl_class->set_role = gdk_broadway_surface_set_role; impl_class->set_startup_id = gdk_broadway_surface_set_startup_id; impl_class->set_transient_for = gdk_broadway_surface_set_transient_for; impl_class->get_frame_extents = gdk_broadway_surface_get_frame_extents; diff --git a/gdk/quartz/gdksurface-quartz.c b/gdk/quartz/gdksurface-quartz.c index ca4a54aaab..86ed03487e 100644 --- a/gdk/quartz/gdksurface-quartz.c +++ b/gdk/quartz/gdksurface-quartz.c @@ -1739,17 +1739,6 @@ gdk_quartz_surface_set_title (GdkSurface *window, } } -static void -gdk_quartz_surface_set_role (GdkSurface *window, - const gchar *role) -{ - if (GDK_SURFACE_DESTROYED (window) || - SURFACE_IS_TOPLEVEL (window)) - return; - - /* FIXME: Implement */ -} - static void gdk_quartz_surface_set_startup_id (GdkSurface *window, const gchar *startup_id) @@ -2754,7 +2743,6 @@ gdk_surface_impl_quartz_class_init (GdkSurfaceImplQuartzClass *klass) impl_class->set_urgency_hint = gdk_quartz_surface_set_urgency_hint; impl_class->set_geometry_hints = gdk_quartz_surface_set_geometry_hints; impl_class->set_title = gdk_quartz_surface_set_title; - impl_class->set_role = gdk_quartz_surface_set_role; impl_class->set_startup_id = gdk_quartz_surface_set_startup_id; impl_class->set_transient_for = gdk_quartz_surface_set_transient_for; impl_class->get_frame_extents = gdk_quartz_surface_get_frame_extents; diff --git a/gdk/wayland/gdksurface-wayland.c b/gdk/wayland/gdksurface-wayland.c index 546226bae0..bc496362b9 100644 --- a/gdk/wayland/gdksurface-wayland.c +++ b/gdk/wayland/gdksurface-wayland.c @@ -3186,12 +3186,6 @@ gdk_wayland_surface_set_title (GdkSurface *surface, gdk_wayland_surface_sync_title (surface); } -static void -gdk_wayland_surface_set_role (GdkSurface *surface, - const gchar *role) -{ -} - static void gdk_wayland_surface_set_startup_id (GdkSurface *surface, const gchar *startup_id) @@ -3858,7 +3852,6 @@ _gdk_surface_impl_wayland_class_init (GdkSurfaceImplWaylandClass *klass) impl_class->set_urgency_hint = gdk_wayland_surface_set_urgency_hint; impl_class->set_geometry_hints = gdk_wayland_surface_set_geometry_hints; impl_class->set_title = gdk_wayland_surface_set_title; - impl_class->set_role = gdk_wayland_surface_set_role; impl_class->set_startup_id = gdk_wayland_surface_set_startup_id; impl_class->set_transient_for = gdk_wayland_surface_set_transient_for; impl_class->get_frame_extents = gdk_wayland_surface_get_frame_extents; diff --git a/gdk/x11/gdksurface-x11.c b/gdk/x11/gdksurface-x11.c index 6f19682c0f..2e3714859e 100644 --- a/gdk/x11/gdksurface-x11.c +++ b/gdk/x11/gdksurface-x11.c @@ -2231,27 +2231,6 @@ gdk_x11_surface_set_title (GdkSurface *surface, } } -static void -gdk_x11_surface_set_role (GdkSurface *surface, - const gchar *role) -{ - GdkDisplay *display; - - display = gdk_surface_get_display (surface); - - if (GDK_SURFACE_DESTROYED (surface) || - !SURFACE_IS_TOPLEVEL (surface)) - return; - - if (role) - XChangeProperty (GDK_DISPLAY_XDISPLAY (display), GDK_SURFACE_XID (surface), - gdk_x11_get_xatom_by_name_for_display (display, "WM_WINDOW_ROLE"), - XA_STRING, 8, PropModeReplace, (guchar *)role, strlen (role)); - else - XDeleteProperty (GDK_DISPLAY_XDISPLAY (display), GDK_SURFACE_XID (surface), - gdk_x11_get_xatom_by_name_for_display (display, "WM_WINDOW_ROLE")); -} - static void gdk_x11_surface_set_startup_id (GdkSurface *surface, const gchar *startup_id) @@ -4684,7 +4663,6 @@ gdk_surface_impl_x11_class_init (GdkSurfaceImplX11Class *klass) impl_class->set_urgency_hint = gdk_x11_surface_set_urgency_hint; impl_class->set_geometry_hints = gdk_x11_surface_set_geometry_hints; impl_class->set_title = gdk_x11_surface_set_title; - impl_class->set_role = gdk_x11_surface_set_role; impl_class->set_startup_id = gdk_x11_surface_set_startup_id; impl_class->set_transient_for = gdk_x11_surface_set_transient_for; impl_class->get_frame_extents = gdk_x11_surface_get_frame_extents; -- 2.30.2